rename: cagent to docker-agent-action across entire repo#4
Merged
Conversation
Complete the rename from 'cagent' to 'docker-agent-action' including: ## Release blockers - B1: release.yml — all docker/cagent-action refs → docker/docker-agent-action - B2: Internal uses: self-refs in review-pr.yml (9 occurrences), review-pr/action.yml (2), review-pr/reply/action.yml (1), review-pr/mention-reply/action.yml (1) → docker/docker-agent-action/...@<sha> - B3: Output rename cagent-version → docker-agent-version with dual-emit (backward compat: old output name still emitted) ## HTML comment markers - cagent-review → docker-agent-review - cagent-review-reply → docker-agent-review-reply Renamed in all TypeScript source, tests, dist/, and action files (~46 places) ## Cosmetic renames - action.yml name: 'cagent Runner' → 'Docker Agent Runner' - action.yml description updated - CAGENT_ACTION_ROOT env var → DOCKER_AGENT_ACTION_ROOT (setup-credentials + consumer) - cagentVersion TS variable → dockerAgentVersion - Branch name auto/update-cagent-action → auto/update-docker-agent-action - Release announce text updated - SECURITY.md, AGENTS.md, review-pr/README.md doc text updated - update-consumers.yml search patterns, commit messages, PR titles updated - test-e2e and test-e2e-reviewer workflows updated ## Preserved as-is - src/migrate-consumer-refs/ search patterns (deliberately searches for old name) - .github/workflows/migrate-consumers.yml (which rewrites old refs in consumer repos) - AGENTS.md:181 description of what migrate-consumers.yml does ## Build - Rebuilt dist/ via pnpm build (tsup) - All 421 unit tests pass
derekmisler
commented
Jun 19, 2026
|
|
||
| core.setOutput('cagent-version', cagentVersion); | ||
| core.setOutput('docker-agent-version', dockerAgentVersion); | ||
| core.setOutput('cagent-version', dockerAgentVersion); // backward compat alias |
Collaborator
Author
There was a problem hiding this comment.
Why do we need the backwards compatibility?
Collaborator
Author
There was a problem hiding this comment.
Consumer workflows that read steps.<id>.outputs.cagent-version would break silently if we dropped the old name immediately. Dual-emit costs nothing and gives consumers a migration window — they can update their workflows to use docker-agent-version at their own pace before we remove the alias in a future major release. We can add a deprecation notice to the docs and drop it in v2.
- review-pr.yml, self-review-pr-trigger.yml, self-review-pr.yml: add
legacy cagent-review/cagent-review-reply exclusion guards alongside
the new docker-agent-review markers, so existing bot comments with
old markers don't re-trigger the review workflow during migration
- release.yml: remove duplicate GITHUB_TOKEN="${GH_TOKEN}" on four
signed-commit invocations (lines 175, 223, 257, 449)
Commit 1b28edd added old-marker fallbacks to the trigger guards, but three read/detect paths still matched only the new docker-agent-review marker (a 1:1 swap from rename commit edf16c1), regressing behavior during the migration window when old `<!-- cagent-review -->` comments coexist with new ones: - review-pr.yml: is_agent feedback detection now matches both review markers and excludes both reply markers, so replies to pre-migration bot review comments still drive the conversational feedback loop. - review-pr/action.yml: stale-thread auto-resolver matches both review markers, so threads opened by the old action are still recognized and auto-resolved. - release.yml: release-notes filter strips both "update cagent-action to v" and "update docker-agent-action to v" so the last pre-rename self-ref bullet does not leak into the first post-rename release notes.
Sayt-0
approved these changes
Jun 19, 2026
Sayt-0
pushed a commit
that referenced
this pull request
Jun 24, 2026
## Problem
The `review-pr` agent exits 0 without posting any GitHub PR comment when
`review_complete=true` and zero findings. The `review_complete=false +
zero findings` path explicitly says 'post a COMMENT review', but the
`review_complete=true` path jumps to step 8 and then step 9 ('Build
inline comments') — with nothing to post, the agent exits silently.
## Changes
### `review-pr/agents/pr-review.yaml` (primary fix)
- **Step 5** (`review_complete=true` + zero findings path): now
explicitly mandates posting a 🟢 APPROVE COMMENT review with an empty
comments array via `gh api` before exiting.
- **Step 8 rule #4**: clarified that the COMMENT event applies even when
the findings list is empty — the assessment-label body must still be
posted.
- **"Delivering the Review" section**: added a concrete zero-findings
bash example with an empty `comments` array, giving the agent a literal
template to follow.
### `review-pr/action.yml` (defense-in-depth)
- **Post-clean-summary step** (`EXIT_CODE=0` branch): added a check — if
the verbose log exists but contains no `pullrequestreview-[0-9]+`
reference, post a fallback issue comment (`🟢 **No issues found** —
LGTM!`) to guarantee PR visibility.
## Testing
- All 470 existing unit tests pass (`pnpm test`).
- Shell tests (`tests/test-job-summary.sh`,
`tests/test-output-extraction.sh`) pass.
- No changes to TypeScript source or `dist/`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the rename from
cagenttodocker-agent-actionacross all files in this repo.Release blockers fixed
release.yml— alldocker/cagent-actionrefs →docker/docker-agent-actionuses:self-references inreview-pr.yml(9),review-pr/action.yml(2),review-pr/reply/action.yml(1),review-pr/mention-reply/action.yml(1) →docker/docker-agent-action/...@<sha>cagent-version→docker-agent-versionwith dual-emit for backward compat (old name still emitted)HTML comment markers
<!-- cagent-review -->→<!-- docker-agent-review --><!-- cagent-review-reply -->→<!-- docker-agent-review-reply -->Cosmetic renames
action.ymlname/description: "cagent Runner" → "Docker Agent Runner"CAGENT_ACTION_ROOT→DOCKER_AGENT_ACTION_ROOTenv var (setup-credentials + consumer in review-pr.yml)cagentVersionTS variable →dockerAgentVersionauto/update-cagent-action→auto/update-docker-agent-actionSECURITY.md,AGENTS.md,review-pr/README.mdupdatedupdate-consumers.yml,test-e2e*.yml,self-review-pr*.ymlupdatedWhat was NOT changed
src/migrate-consumer-refs/— deliberately searches for old name in consumer repos.github/workflows/migrate-consumers.yml— searches/rewrites old refs in consumer reposAGENTS.mdrow describing what migrate-consumers does (it rewrites old refs)Testing
pnpm test)pnpm build(tsup) succeeds with clean output